[webkit-reviews] review denied: [Bug 119559] [EFL] Web Inspector: Move to new web inspector : [Attachment 210365] patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Marcelo Morais
<m.morais at samsung.com>'s request for review:
Bug 119559: [EFL] Web Inspector: Move to new web inspector
https://bugs.webkit.org/show_bug.cgi?id=119559

Attachment 210365: patch
https://bugs.webkit.org/attachment.cgi?id=210365&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210365&action=review


R- because of wrong ChangeLog.

> Source/WebKit2/ChangeLog:11
> +	   * WebCoreSupport/InspectorClientEfl.cpp:

This patch doesn't touch WebCoreSupport/InspectorClientEfl.cpp.

> Source/WebKit2/ChangeLog:14
> +	   (WebKit::WebInspectorProxy::inspectorPageURL):

Please mention what is changed here.

> Source/WebKit2/ChangeLog:15
> +	   * Source/PlatformEfl.cmake:

I wonder why this file is mentioned in WebKit2/ChangeLog. Don't you generate
ChangeLog using Prepare-ChangeLog script ?