[webkit-reviews] review granted: [Bug 120564] Converting StackIterator to a callback interface : [Attachment 210405] patch 4: Removed StackIterator::Functor.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 3 16:51:10 PDT 2013


Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 120564: Converting StackIterator to a callback interface
https://bugs.webkit.org/show_bug.cgi?id=120564

Attachment 210405: patch 4: Removed StackIterator::Functor.
https://bugs.webkit.org/attachment.cgi?id=210405&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210405&action=review


r=me if you come up with a better name for that one functor.

> Source/WebCore/bindings/js/ScriptCallStackFactory.cpp:102
> +class CreateScriptCallStackFunctor2 {

Better name?  It's OK to be descriptive.


More information about the webkit-reviews mailing list