[webkit-reviews] review requested: [Bug 116831] [GStreamer] cannot play live streams : [Attachment 210406] Patch

[bugzilla-daemon at webkit.org]

Andre Moreira Magalhaes <andrunko at gmail.com> has asked	for review:
Bug 116831: [GStreamer] cannot play live streams
https://bugs.webkit.org/show_bug.cgi?id=116831

Attachment 210406: Patch
https://bugs.webkit.org/attachment.cgi?id=210406&action=review

------- Additional Comments from Andre Moreira Magalhaes <andrunko at gmail.com>
(In reply to comment #5)
> While working on the fix for rtsp links embedded on <video> I hit an issue
adding 2 required gst-plugins-good patches to jhbuild.
> 
> The problem is that we are using git repos + tags for gstreamer modules and
jhbuild only supports adding patches to tarball repos it seems.
> 
> So, any reason to use git repos + tags instead of release tarballs for
jhbuild gstreamer modules? Should we bump version to git tag 1.0.10 for all gst
modules except for gst-plugins-good, where we could use 1.0/HEAD (54a7fa - have
the required patches applied)?
> 
> To avoid having regressions I think we should change to use 1.0.8 tarballs +
the required gst-plugins-good patches to fix rtsp timeout handling.
> 
> What do you think?

Ok, the attached patch changes the gstreamer jhbuild modules to use tarballs
and include the required patches to make rtsp streams work.

The patch fix loading for ManualTests/video-rtsp.html and any link
http://demo.smart-streaming.com/fms/demo/mobile.html if added as <video> src.
The patch does not fix the "URL cannot be shown" issues when clicking on
rtsp:// links directly though.