[webkit-reviews] review granted: [Bug 120627] [GTK] Add support for the Wayland build target : [Attachment 210363] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 120627: [GTK] Add support for the Wayland build target
https://bugs.webkit.org/show_bug.cgi?id=120627

Attachment 210363: Patch
https://bugs.webkit.org/attachment.cgi?id=210363&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=210363&action=review


> Source/WebCore/ChangeLog:15
> +	   (gdk_screen_get_monitor_workarea): Additionally guard bits of code
that depend on the GTK_WINDOWING_X11 macro being

s/GTK/GDK/

> Source/autotools/FindDependencies.m4:204
> +    AC_MSG_WARN([X11 target support not enabled, disabling GLX support.])
> +    enable_glx=no

Perhaps this should only warn if enable_glx was true.

> Source/autotools/FindDependencies.m4:298
> +if test "$with_x11_target" != "yes" && test "$with_wayland_target" = "yes"
&& test "enable_accelerated_compositing" != "no"; then

I think it's weird how we test for != "yes", = "yes", != "no" quite
inconsistently heh, just saying though, no need for changing.

> Source/autotools/ReadCommandLineArguments.m4:62
> +# To support building for X11 and Wayland targets concurrently, the
$with_target value is checked for this
> +# special case and two additional variables are introduced that denote
specifically whether we're building
> +# the X11 target, the Wayland target, both of these or neither.

Cunning.