[webkit-reviews] review granted: [Bug 120637] Support Vector<Ref<T>>. : [Attachment 210394] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 120637: Support Vector<Ref<T>>.
https://bugs.webkit.org/show_bug.cgi?id=120637

Attachment 210394: Patch
https://bugs.webkit.org/attachment.cgi?id=210394&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=210394&action=review


ok

> Source/WebCore/page/Page.cpp:1201
> +
> +    return views;
>  }

With our current vector implementation do we avoid doing vector copy here?

> Source/WebCore/page/Page.cpp:1210
> +    auto views = pluginViews();

It is bit non-obvious what the return type is. Would something like
pluginViewsAsVector be helpful?