[webkit-reviews] review requested: [Bug 120567] CodeBlock::jettison() should be implicit : [Attachment 210303] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 2 11:44:52 PDT 2013


Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 120567: CodeBlock::jettison() should be implicit
https://bugs.webkit.org/show_bug.cgi?id=120567

Attachment 210303: the patch
https://bugs.webkit.org/attachment.cgi?id=210303&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Updated patch that more rigorously tracks CodeBlock memory footprint.  I
discovered bugs in our memory footprint tracking when trying to track down the
JSBench/google regression.  This version of the patch is very precise -
CodeBlocks will report extra memory cost on allocation, and then again when
setJITCode() is called, and then again during GC to remind it that we're still
using memory.


More information about the webkit-reviews mailing list