[webkit-reviews] review requested: [Bug 117354] [GStreamer] Don't set state to NULL until element is destroyed : [Attachment 210293] Patch

[bugzilla-daemon at webkit.org]

Andre Moreira Magalhaes <andrunko at gmail.com> has asked	for review:
Bug 117354: [GStreamer] Don't set state to NULL until element is destroyed
https://bugs.webkit.org/show_bug.cgi?id=117354

Attachment 210293: Patch
https://bugs.webkit.org/attachment.cgi?id=210293&action=review

------- Additional Comments from Andre Moreira Magalhaes <andrunko at gmail.com>
(In reply to comment #9)
> (From update of attachment 210140 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=210140&action=review
> 
> >
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:291
> > +	 if (m_readyTimerHandler)
> > +	     g_source_remove(m_readyTimerHandler);
> 
> Shouldn't this be done before m_playBin is cleared? Otherwise the timer might
fire with an invalid player pointer?
>
Changed to remove the source before m_playBin is cleared. The change is not
actually required as the timer would not be fired in the destructor (same
thread and no one calling main_loop_iterate) but doesn't hurt.
 
> >
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:413
> > +	 // See also https://bugzilla.gnome.org/show_bug.cgi?id=117354
> 
> That bug seems quite unrelated :)
hehe, oops, fixed :)

Also rebased against upstream/master and fixed conflicts.