[webkit-reviews] review granted: [Bug 120529] Simplify DocumentType handling. : [Attachment 210292] Less crappy patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 120529: Simplify DocumentType handling.
https://bugs.webkit.org/show_bug.cgi?id=120529

Attachment 210292: Less crappy patch
https://bugs.webkit.org/attachment.cgi?id=210292&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=210292&action=review


r=me

> Source/WebCore/ChangeLog:19
> +	   Removed the insertedInto()/removedFrom() handlers from DocumentType.

> +
> +	   Document no longer keeps a pointer to its doctype node, it was only
used for the
> +	   document.doctype DOM API, which now just looks through the list of
(<=2) children.
> +
> +	   The ENABLE(LEGACY_VIEWPORT_ADAPTION) hunk from
Document::setDocType() was moved
> +	   into Document::childrenChanged().
> +
> +	   We no longer clear the style resolver on doctype insertion/removal
since it
> +	   doesn't actually affect style anyway.
> +
> +	   Also made doctype() return a PassRefPtr<DocumentType> instead of a
raw pointer.

Would be good to mention that the DOM spec says dynamic doctype changes have no
effect, maybe even in a code comment.