[webkit-reviews] review granted: [Bug 120599] Clean up ContainerNode::childrenChanged : [Attachment 210276] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120599: Clean up ContainerNode::childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=120599

Attachment 210276: patch
https://bugs.webkit.org/attachment.cgi?id=210276&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210276&action=review


r=me. Way cool.

> Source/WebCore/html/HTMLElement.h:111
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE plz

> Source/WebCore/html/HTMLObjectElement.h:79
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/html/HTMLOptGroupElement.h:52
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/html/HTMLOptionElement.h:82
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/html/HTMLOutputElement.h:62
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/html/HTMLScriptElement.h:49
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/html/HTMLSelectElement.h:182
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/html/HTMLStyleElement.h:69
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/html/HTMLTextAreaElement.h:99
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/svg/SVGClipPathElement.h:49
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/svg/SVGElement.h:163
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE!!!!

> Source/WebCore/svg/SVGFELightElement.h:47
> +    virtual void childrenChanged(const ChildChange&);

Another OVERRIDE

> Source/WebCore/svg/SVGFilterElement.h:55
> +    virtual void childrenChanged(const ChildChange&);

Yep, OVERRIDE

> Source/WebCore/svg/SVGFontFaceElement.h:60
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE!

> Source/WebCore/svg/SVGFontFaceFormatElement.h:35
> +    virtual void childrenChanged(const ChildChange&);

UNDER... wait no OVERRIDE

> Source/WebCore/svg/SVGFontFaceSrcElement.h:39
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/svg/SVGFontFaceUriElement.h:44
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/svg/SVGGradientElement.h:100
> +    virtual void childrenChanged(const ChildChange&);

Maximum OVERRIDE

> Source/WebCore/svg/SVGMarkerElement.h:131
> +    virtual void childrenChanged(const ChildChange&);

override

> Source/WebCore/svg/SVGMaskElement.h:50
> +    virtual void childrenChanged(const ChildChange&);

OVERRIDE

> Source/WebCore/svg/SVGPatternElement.h:64
> +    virtual void childrenChanged(const ChildChange&);

OvErRiDe

> Source/WebCore/svg/SVGScriptElement.h:51
> +    virtual void childrenChanged(const ChildChange&);

O-Ride

> Source/WebCore/svg/SVGStyleElement.h:57
> +    virtual void childrenChanged(const ChildChange&);

overRide

> Source/WebCore/svg/SVGTitleElement.h:39
> +    virtual void childrenChanged(const ChildChange&);

o-v-e-r-r-i-d-e