[webkit-reviews] review denied: [Bug 98350] [GTK] accessibility/aria-invalid.html times out : [Attachment 209982] Patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied Anton Obzhirov
<a.obzhirov at samsung.com>'s request for review:
Bug 98350: [GTK] accessibility/aria-invalid.html times out
https://bugs.webkit.org/show_bug.cgi?id=98350

Attachment 209982: Patch
https://bugs.webkit.org/attachment.cgi?id=209982&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209982&action=review


(In reply to comment #4)
> Created an attachment (id=209982) [details]
> Patch

Looks good to me now (and after SVN revision r154697 the
addNotificationListener implementation is no longer an issue in DRT. However, I
believe you will need to keep the aria-invalid test skipped for WK2 only since
we still don't have addNotificationListener for AccessibilityUIElement in WKTR,
hence it will still timeout there.

> LayoutTests/platform/gtk/TestExpectations:-783
> -webkit.org/b/98350 accessibility/aria-invalid.html [ Timeout ]

I would suggest to move this line to the TestExpectations file in gtk-wk2 and
reference it against bug 120421 (which tracks the missing implementation of
addNotificationListner in WKTR