[webkit-reviews] review denied: [Bug 120598] [EFL] Synchronize caret interval with that of EFL entry : [Attachment 210275] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 2 05:59:37 PDT 2013

Christophe Dumez <dchris at gmail.com> has denied Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 120598: [EFL] Synchronize caret interval with that of EFL entry

Attachment 210275: Patch

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210275&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.h:119
> +    virtual double caretBlinkInterval() const { return 0.6; }

Would you please move the implementation to the cpp file, add a global constant
for the magic 0.6 value with a comment explaining why we use this value?

More information about the webkit-reviews mailing list