[webkit-reviews] review denied: [Bug 120577] REGRESSION (r154881): Crash on Macworld.com when expanding comments : [Attachment 210272] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 2 03:49:21 PDT 2013


Antti Koivisto <koivisto at iki.fi> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 120577: REGRESSION (r154881): Crash on Macworld.com when expanding comments
https://bugs.webkit.org/show_bug.cgi?id=120577

Attachment 210272: Patch
https://bugs.webkit.org/attachment.cgi?id=210272&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
This is wrong. attributeAt(index) is invoked on the line above. I suspect that
the bug is that attributeName should be captured into a local variable instead
of a reference.

This needs a test case.


More information about the webkit-reviews mailing list