[webkit-reviews] review granted: [Bug 120584] Generate isFooElement() functions from tagname data. : [Attachment 210253] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 120584: Generate isFooElement() functions from tagname data.
https://bugs.webkit.org/show_bug.cgi?id=120584

Attachment 210253: Patch
https://bugs.webkit.org/attachment.cgi?id=210253&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=210253&action=review


r=me, nice, so much red!

> Source/WebCore/dom/make_names.pl:648
> +sub printTypeChecksHeaderFile
> +{
> +    my ($headerPath) = shift;
> +    my $F;
> +    open F, ">$headerPath";
> +    printLicenseHeader($F);
> +

Could this include some information about how the file was generated on top of
the header?

> Source/WebCore/html/HTMLTagNames.in:27
>  body
>  br interfaceName=HTMLBRElement
>  button constructorNeedsFormElement
> -canvas
> +canvas generateTypeChecks
>  caption interfaceName=HTMLTableCaptionElement

It would nice to get these for all types where it works (either automatically
or adding generateTypeChecks). It is kinda non-obvious you need to locate this
file and add some magic keywords to fix the problem.