[webkit-reviews] review granted: [Bug 120579] HitTestResult should have innerNonSharedElement : [Attachment 210240] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 1 07:41:56 PDT 2013


Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 120579: HitTestResult should have innerNonSharedElement
https://bugs.webkit.org/show_bug.cgi?id=120579

Attachment 210240: Patch
https://bugs.webkit.org/attachment.cgi?id=210240&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210240&action=review


r=me

> Source/WebCore/ChangeLog:14
> +	   the node and chenking if it's an input element. Also added some
missing braces.

Typo, checking.

> Source/WebCore/page/Chrome.cpp:439
> +	   if (Node* element = result.innerNonSharedElement()) {

You should use an Element* pointer here.


More information about the webkit-reviews mailing list