[webkit-reviews] review denied: [Bug 120572] ASSERT if port don't have color picker implemenation by inheriting webcolorpicker : [Attachment 210228] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 1 07:18:10 PDT 2013


Darin Adler <darin at apple.com> has denied Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 120572: ASSERT if port don't have color picker implemenation by inheriting
webcolorpicker
https://bugs.webkit.org/show_bug.cgi?id=120572

Attachment 210228: Patch
https://bugs.webkit.org/attachment.cgi?id=210228&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is not a useful assertion. Don’t turn on INPUT_TYPE_COLOR without
implementing createColorPicker. An assertion is not a helpful way to go further
with this. The null dereference happens on the next line of code!


More information about the webkit-reviews mailing list