[webkit-reviews] review canceled: [Bug 120564] Converting StackIterator to a callback interface : [Attachment 210202] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 1 01:29:42 PDT 2013


Mark Lam <mark.lam at apple.com> has canceled Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 120564: Converting StackIterator to a callback interface
https://bugs.webkit.org/show_bug.cgi?id=120564

Attachment 210202: the patch.
https://bugs.webkit.org/attachment.cgi?id=210202&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
To answer Filip, there's no reason why we shouldn't use functors for the
callback instead.  It's just an oversight of mine.  Patch 2 applies the functor
pattern and makes StackIterator::iterate() a template function.


More information about the webkit-reviews mailing list