[webkit-reviews] review granted: [Bug 123310] Underline bounds cannot be queried before underline itself is drawn : [Attachment 215668] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 123310: Underline bounds cannot be queried before underline itself is drawn
https://bugs.webkit.org/show_bug.cgi?id=123310

Attachment 215668: Patch
https://bugs.webkit.org/attachment.cgi?id=215668&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215668&action=review


> Source/WebCore/ChangeLog:32
> +	   * platform/graphics/GraphicsContext.h: Signature of new
computeLineBoundsForText
> +	   function
> +	   * platform/graphics/blackberry/PathBlackBerry.cpp:
> +	   (WebCore::GraphicsContext::computeLineBoundsForText): Implement new
function
> +	   * platform/graphics/cairo/GraphicsContextCairo.cpp:
> +	   (WebCore::GraphicsContext::computeLineBoundsForText): Ditto
> +	   (WebCore::GraphicsContext::drawLineForText): Use
computeLineBoundsForText
> +	   * platform/graphics/cg/GraphicsContextCG.cpp:
> +	   (WebCore::computeLineBoundsAndAntialiasingModeForText): Static
function that
> +	   performs the actual bounds computation
> +	   (WebCore::GraphicsContext::computeLineBoundsForText): Calls
> +	   computeLineBoundsAndAntialiasingModeForText
> +	   (WebCore::GraphicsContext::drawLineForText): Use new function
> +	   * platform/graphics/wince/GraphicsContextWinCE.cpp:
> +	   (WebCore::GraphicsContext::computeLineBoundsForText): Implement new
function

Super nit: end comments with periods.