[webkit-reviews] review granted: [Bug 123582] [WebCrypto] Add SHA-1 : [Attachment 215664] with a better skip list

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 123582: [WebCrypto] Add SHA-1
https://bugs.webkit.org/show_bug.cgi?id=123582

Attachment 215664: with a better skip list
https://bugs.webkit.org/attachment.cgi?id=215664&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215664&action=review


> Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:49
> +	   return 0;

nullptr.

> Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:55
> +    return std::move(result);

No need for std::move here.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA1.h:38
> +    static const char* const m_name;
> +    static const CryptoAlgorithmIdentifier m_identifier =
CryptoAlgorithmIdentifier::SHA_1;

We usually don’t use m_ for public member variables, at least I don’t think we
do.