[webkit-reviews] review granted: [Bug 123557] WebPageCreationParameters should be consistent in Window.open : [Attachment 215619] Fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 123557: WebPageCreationParameters should be consistent in Window.open
https://bugs.webkit.org/show_bug.cgi?id=123557

Attachment 215619: Fix
https://bugs.webkit.org/attachment.cgi?id=215619&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215619&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:3838
> +    WebPageCreationParameters& parameters = m_creationParameters;

You should not do this and instead just use m_creationParameters.