[webkit-reviews] review granted: [Bug 121827] [WIN] Reduce usage of CFSTR() in WebPreferences : [Attachment 212437] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 121827: [WIN] Reduce usage of CFSTR() in WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=121827

Attachment 212437: Patch
https://bugs.webkit.org/attachment.cgi?id=212437&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212437&action=review


This seems reasonable, since it doesn't change any of the interfaces we are
working with

Be careful with changes here: we want to make sure that we don't break any
existing functionality -- there are existing serialized preference databases
that rely on the CF infrastructure to read and modify.

This change will not affect any of those targets, but when  you start modifying
"migrateWebKitPreferencesToCFPreferences" or
"copyWebKitPreferencesToCFPreferences" and especially "load" and "save" you
have to be very careful.

> Source/WebKit/win/WebPreferences.cpp:320
> +BSTR WebPreferences::stringValueForKey(const char* key)

Note (for your future modifications): This routine (and several others) could
greatly benefit from using _bstr_t instead of all of this manual
SysAllocStringLen stuff.