[webkit-reviews] review denied: [Bug 122010] [WIN] Make WebHistory compile without USE(CF) : [Attachment 212800] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 122010: [WIN] Make WebHistory compile without USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=122010

Attachment 212800: Patch
https://bugs.webkit.org/attachment.cgi?id=212800&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212800&action=review


Looks good to me. Please correct the bracket placement and we can land this.

>> Source/WebKit/win/COMVariantSetter.h:125
>> +{
> 
> This { should be at the end of the previous line  [whitespace/braces] [4]

Please correct this bracket position.

>> Source/WebKit/win/WebHistory.cpp:88
>>  }
> 
> Does not make sense to have both of these. Why keep the CF version?

We need the CF versions to maintain compatibility with other software.