[webkit-reviews] review granted: [Bug 123474] Add a crypto algorithm abstraction : [Attachment 215432] proposed patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 123474: Add a crypto algorithm abstraction
https://bugs.webkit.org/show_bug.cgi?id=123474

Attachment 215432: proposed patch
https://bugs.webkit.org/attachment.cgi?id=215432&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215432&action=review


> Source/WebCore/crypto/CryptoAlgorithm.h:32
> +#include <wtf/Vector.h>
> +#include "CryptoAlgorithmIdentifier.h"
> +#include "CryptoKeyFormat.h"
> +#include "CryptoKeyUsage.h"

Sort please.

> Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp:39
> +//	 registerAlgorithm(CryptoAlgorithmHMAC::m_name,
CryptoAlgorithmHMAC::m_identifier, CryptoAlgorithmHMAC::create);
> +//	 registerAlgorithm(CryptoAlgorithmSHA1::m_name,
CryptoAlgorithmSHA1::m_identifier, CryptoAlgorithmSHA1::create);

We don't usually check in commented out code.