[webkit-reviews] review granted: [Bug 123199] [WINCE]Input tag of range type is not painted : [Attachment 215014] Paint the input tag of range type on WinCE port.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 31 09:51:22 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 123199: [WINCE]Input tag of range type is not painted
https://bugs.webkit.org/show_bug.cgi?id=123199

Attachment 215014: Paint the input tag of range type on WinCE port.
https://bugs.webkit.org/attachment.cgi?id=215014&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215014&action=review


r=me

> Source/WebCore/rendering/RenderThemeWinCE.cpp:512
> +    return false;

It's strange that we expect these methods to always return 'false'. Doesn't
seem like there is much point in having a return value!


More information about the webkit-reviews mailing list