[webkit-reviews] review granted: [Bug 123574] Remove CachedTranscendentalFunction because caching math functions is an ugly idea : [Attachment 215656] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 123574: Remove CachedTranscendentalFunction because caching math functions
is an ugly idea
https://bugs.webkit.org/show_bug.cgi?id=123574

Attachment 215656: the patch
https://bugs.webkit.org/attachment.cgi?id=215656&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215656&action=review


r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:570
> +	       setConstant(node, jsNumber(sin(child.asNumber())));

Is this supposed to be cos?

> Source/JavaScriptCore/runtime/DateInstanceCache.h:29
> +#include "JSCJSValue.h"

Is this necessary?