[webkit-reviews] review denied: [Bug 123479] AX: Audio and Video attachments are not output to VoiceOver : [Attachment 215584] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 123479: AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Attachment 215584: patch
https://bugs.webkit.org/attachment.cgi?id=215584&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215584&action=review


> LayoutTests/ChangeLog:9
> +	   Making media elements be replaced in TextIterating has the
unfortunate effect
> +	   of causing a new line to be inserted into any test using a <video>
tag.

That's weird, specially because it seems the new line is neither inserted
before nor after the video, but at some "random" place at the beginning of the
output...

Maybe it's worth checking if that could be fixed instead of doing this massive
rebaselining? In any case, if rebaselining turns out to be a better option I
think we first need to figure out why all those tests keep failing in the EWS
in the mac.

Setting the r- because of the EWS output (which seems related)