[webkit-reviews] review granted: [Bug 123399] [EFL][GLES] OpenGL should be an optional : [Attachment 215284] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 30 23:52:38 PDT 2013


Noam Rosenthal <noam at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 123399: [EFL][GLES] OpenGL should be an optional
https://bugs.webkit.org/show_bug.cgi?id=123399

Attachment 215284: Patch
https://bugs.webkit.org/attachment.cgi?id=215284&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215284&action=review


OK, but please fix English.

> Source/WebCore/ChangeLog:3
> +	   [EFL][GLES] OpenGL should be an optional

an optional -> optional

> Source/WebCore/ChangeLog:10
> +	   Move OpenGL macro to OptionsEfl.cmake and Make Xcomposite and
XRender as optional.

Make -> make


More information about the webkit-reviews mailing list