[webkit-reviews] review granted: [Bug 123443] Simplifying MediaStream and MediStreamDescriptor creation : [Attachment 215583] Final patch (I hope)

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 123443: Simplifying MediaStream and MediStreamDescriptor creation
https://bugs.webkit.org/show_bug.cgi?id=123443

Attachment 215583: Final patch (I hope)
https://bugs.webkit.org/attachment.cgi?id=215583&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215583&action=review


> Source/WebCore/platform/mediastream/MediaStreamDescriptor.h:59
> +    static PassRefPtr<MediaStreamDescriptor> create(const
Vector<RefPtr<MediaStreamTrackPrivate>>& audioPrivateTracks, const
Vector<RefPtr<MediaStreamTrackPrivate>>& videoPrivateTracks);

Nit: I think this can be made private, for now at least. This can be done in a
follow-up.