[webkit-reviews] review granted: [Bug 123528] Teach the style checker about ENUM_CLASS : [Attachment 215570] proposed patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 123528: Teach the style checker about ENUM_CLASS
https://bugs.webkit.org/show_bug.cgi?id=123528

Attachment 215570: proposed patch
https://bugs.webkit.org/attachment.cgi?id=215570&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215570&action=review


r=me

> Tools/Scripts/webkitpy/style/checkers/cpp.py:1196
> +	   expr_enum_start =
r'\s*(?:enum(?:\s+[a-zA-Z0-9]+)?|ENUM_CLASS\s*\([a-zA-Z0-9]+\))\s*\{?\s*'

Does the ([a-zA-Z0-9]+\) need to be non-capturing? Not sure it matters since
only named groups are used.