[webkit-reviews] review denied: [Bug 123485] WebKit/win/WebKitGraphics.h:void WebDrawText(WebTextRenderInfo*); is never called : [Attachment 215545] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 123485: WebKit/win/WebKitGraphics.h:void WebDrawText(WebTextRenderInfo*);
is never called
https://bugs.webkit.org/show_bug.cgi?id=123485

Attachment 215545: Patch
https://bugs.webkit.org/attachment.cgi?id=215545&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215545&action=review


Sorry -- I missed one thing, and we need a ChangeLog on the
"WebKitExports.def.in" change.

> Source/WebKit/win/ChangeLog:8
> +	   * WebKitGraphics.cpp:

You should say something like "Removed unused WebDrawText implementation."

> Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:-14
> -	   WebDrawText

Unfortunately, this file is in the scope of "Source/WebKit/ChangeLog" (not just
the "Source/WebKit/win/ChangeLog"), so yet ANOTHER ChangeLog is needed. 
"prepare-ChangeLog" should get it set up properly for you.