[webkit-reviews] review granted: [Bug 122602] contentEditable deleting lists when list items are block level : [Attachment 215517] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 122602: contentEditable deleting lists when list items are block level
https://bugs.webkit.org/show_bug.cgi?id=122602

Attachment 215517: Patch
https://bugs.webkit.org/attachment.cgi?id=215517&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215517&action=review


> Source/WebCore/ChangeLog:19
> +	   When listitems are styled with display:block/float then inserting
paragraph twice at end
> +	   of listitem delete entire list. Generally when listitem is empty
then we
> +	   delete the listitem on inserting paragraph. In this issue, on
> +	   inserting first paragraph one empty listitem is created, and on
inserting
> +	   second paragraph we try to delete that empty listitem. but it
misbehave becasue
> +	   of incomplete definition of htmlediting::isLisItem() and entire list
is deleted.
> +
> +	   htmlediting::isListItem() check only render object to decide whether

> +	   it is list or not, so if any LI element is block level then
isListItem
> +	   return false.
> +	   Now after this patch if parent of current node is list element then
node is
> +	   treated as listItem.

Could you reformat this change log so that each line end at a similar length /
at a sensible location.
e.g. ending a line with "on" is awkward.