[webkit-reviews] review requested: [Bug 121837] [WIN] Add executable entry points to DRT and WinLauncher : [Attachment 212457] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 30 10:22:38 PDT 2013


Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 121837: [WIN] Add executable entry points to DRT and WinLauncher
https://bugs.webkit.org/show_bug.cgi?id=121837

Attachment 212457: Patch
https://bugs.webkit.org/attachment.cgi?id=212457&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #4)
> (From update of attachment 212457 [details])
> We will not accept this patch, as it removes functionality we need.

It does not remove functionality! It's ok that the Apple port needs the
*Launcher applications, but the Cairo port does not. Having additional binaries
adds no value there. I don't see a big problem in splitting this function, so
the build system can decide how to link it (with or without *Launcher)


More information about the webkit-reviews mailing list