[webkit-reviews] review granted: [Bug 120998] [Win] Compile errors when enabling DFG JIT. : [Attachment 214863] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 120998: [Win] Compile errors when enabling DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=120998

Attachment 214863: Patch
https://bugs.webkit.org/attachment.cgi?id=214863&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214863&action=review


Thanks for resolving those issues. This looks fine to me.

r=me

> Source/WTF/wtf/ThreadingOnce.h:68
> +    bool m_calledOnce;

It's a shame that Windows doesn't provide this functionality. A future
improvement might be to base this on whatever Windows uses to handle "do this
once" functionality. Perhaps that is just a mutex and a flag, but when we move
to 64-bit, we will have access to more modern OS features, which might be
helpful here.