[webkit-reviews] review granted: [Bug 123153] [ATK] Avoid explicit traversal of text controls and the render tree in AtkText implementation : [Attachment 215501] Patch proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 123153: [ATK] Avoid explicit traversal of text controls and the render tree
in AtkText implementation
https://bugs.webkit.org/show_bug.cgi?id=123153

Attachment 215501: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=215501&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215501&action=review


minor comment. I think it's OK to collapse those for now. Mac may eventually
want to use the emitsObjectReplacement and I think we'd also want the same
children behavior GTK wants

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:657
> +	   if (m_renderer->node()) {

you can probably do a if (Node* node = m_renderer->node()) and then get rid of
the next if check. 
I know sometimes those results might be different but I'm pretty sure
AXrenderObject's node() method just does m_renderer->node() anyway