[webkit-reviews] review denied: [Bug 123277] REGRESSION(r157164): v8-v6/v8-raytrace.js crashes on arm and sh4 : [Attachment 215444] Use regTx instead of nonArgGPRx in virtualForThunkGenerator function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 29 16:49:06 PDT 2013


Filip Pizlo <fpizlo at apple.com> has denied Julien Brianceau
<jbriance at cisco.com>'s request for review:
Bug 123277: REGRESSION(r157164): v8-v6/v8-raytrace.js crashes on arm and sh4
https://bugs.webkit.org/show_bug.cgi?id=123277

Attachment 215444: Use regTx instead of nonArgGPRx in virtualForThunkGenerator
function
https://bugs.webkit.org/attachment.cgi?id=215444&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I think this is wrong.	The point of using nonArgGPR is that we want to use a
register that isn't an argument.  regT0 may be an argument register on some
platforms.  I think that the correct change is to make sure that when the JITs
make calls, they use nonArgGPR for the callee.


More information about the webkit-reviews mailing list