[webkit-reviews] review granted: [Bug 123461] CryptoAlgorithmDescriptionBuilder should support producing nested algorithms : [Attachment 215415] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 123461: CryptoAlgorithmDescriptionBuilder should support producing nested
algorithms
https://bugs.webkit.org/show_bug.cgi?id=123461

Attachment 215415: proposed patch
https://bugs.webkit.org/attachment.cgi?id=215415&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215415&action=review


> Source/WebCore/bindings/js/JSCryptoAlgorithmBuilder.cpp:49
> +    return std::unique_ptr<CryptoAlgorithmDescriptionBuilder>(new
JSCryptoAlgorithmBuilder(m_exec));

We should use make_unique here.

> Source/WebCore/bindings/js/JSCryptoAlgorithmBuilder.cpp:70
> +    const JSCryptoAlgorithmBuilder* jsBuilder = static_cast<const
JSCryptoAlgorithmBuilder*>(nestedBuilder);

What guarantees this is a good cast?

> Source/WebCore/bindings/js/JSCryptoAlgorithmBuilder.h:51
> +    virtual void add(const char*, const CryptoAlgorithmDescriptionBuilder*)
OVERRIDE;

Why is this a pointer, not a reference?