[webkit-reviews] review denied: [Bug 123355] Move InlineTextBox's text painting to its own class : [Attachment 215328] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 29 14:49:31 PDT 2013


Dean Jackson <dino at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 123355: Move InlineTextBox's text painting to its own class
https://bugs.webkit.org/show_bug.cgi?id=123355

Attachment 215328: Patch
https://bugs.webkit.org/attachment.cgi?id=215328&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215328&action=review


Looks good, just needs license change.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:11736
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBui
ld>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild
>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'">true</Exclud
edFromBuild>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|x64'">true</Excluded
FromBuild>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|Win32'">true</ExcludedF
romBuild>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|x64'">true</ExcludedFro
mBuild>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromB
uild>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</ExcludedFromBui
ld>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'">true</Excl
udedFromBuild>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|x64'">true</Exclud
edFromBuild>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFr
omBuild>
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFrom
Build>

I'm not sure we need all this crap. I tend to leave it out and see what breaks.


> Source/WebCore/rendering/TextPainter.cpp:18
> + * Copyright (C) 2013 Apple Inc. All rights reserved.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License

> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + *

This is not the right license. Look for a recently added file by an apple
contributor and copy it from there. e.g.
Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm

> Source/WebCore/rendering/TextPainter.h:18
> + * Copyright (C) 2013 Apple Inc. All rights reserved.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License

> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + *

Ditto.


More information about the webkit-reviews mailing list