[webkit-reviews] review granted: [Bug 123346] [CSS Regions][CSS Shapes] Layout error when the shape has negative top coordinate and it's applied on the second region : [Attachment 215192] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 123346: [CSS Regions][CSS Shapes] Layout error when the shape has negative
top coordinate and it's applied on the second region
https://bugs.webkit.org/show_bug.cgi?id=123346

Attachment 215192: Patch
https://bugs.webkit.org/attachment.cgi?id=215192&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215192&action=review


r=me

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1447
> +	   if (!shapeTopOffset && (0 < shapeInsideInfo->shapeLogicalTop()))

We don't typically put the constants on the left. I'd change this to
shapeInsideInfo->shapeLogicalTop() > 0