[webkit-reviews] review granted: [Bug 123459] Make SimpleLineLayout::Layout a variable size object : [Attachment 215412] better patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 29 13:01:29 PDT 2013
Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 123459: Make SimpleLineLayout::Layout a variable size object
https://bugs.webkit.org/show_bug.cgi?id=123459
Attachment 215412: better patch
https://bugs.webkit.org/attachment.cgi?id=215412&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215412&action=review
Very cool. r=me
> Source/WebCore/rendering/SimpleLineLayout.cpp:61
> -#endif
> +#endif
why
> Source/WebCore/rendering/SimpleLineLayout.h:62
> + Run runs[0];
You may need some #pragma tomfoolery to placate MSVC. See ElementData.h
More information about the webkit-reviews
mailing list