[webkit-reviews] review granted: [Bug 123451] Get IDBTransactionBackendLevelDBOperations *almost* ready to go cross platform : [Attachment 215410] Patch v3 - Make a method pure virtual that should already have been.

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 123451: Get IDBTransactionBackendLevelDBOperations *almost* ready to go
cross platform
https://bugs.webkit.org/show_bug.cgi?id=123451

Attachment 215410: Patch v3 - Make a method pure virtual that should already
have been.
https://bugs.webkit.org/attachment.cgi?id=215410&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215410&action=review


r=me.

> Source/WebCore/ChangeLog:11
> +	   - Reworking the LeveDB Operations to handle the base class
IDBTransactionBackendInterface

Typo, LevelDB

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:423
> +    Deque<OwnPtr<IDBPendingOpenCall>> pendingOpenCalls;
>      m_pendingOpenCalls.swap(pendingOpenCalls);

This would look slightly more straightforward like so:
Deque<OwnPtr<IDBPendingOpenCall>> pendingOpenCalls =
std::move(m_pendingOpenCalls);

Hm, I wonder if we couldn't even do this:
auto pendingOpenCalls = std::move(m_pendingOpenCalls);