[webkit-reviews] review granted: [Bug 123450] WebKit2 bots don't exit after 50 failures or timeouts : [Attachment 215400] set shouldAbortEarly to True

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 123450: WebKit2 bots don't exit after 50 failures or timeouts
https://bugs.webkit.org/show_bug.cgi?id=123450

Attachment 215400: set shouldAbortEarly to True
https://bugs.webkit.org/attachment.cgi?id=215400&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This was changed in bug 94506, apparently because WK2 used to have lots and
lots of flaky tests, so letting these run to completion still gave you some
information about non-flakily failing tests.

We are not there any more with respect to how horrible tests are, and allowing
an unlimited number of crashes or timeouts grinds bots to a halt after a bad
commit that crashes everywhere.

Alternatively to landing this change, we could roll out the one from bug 94506.
What do you think?