[webkit-reviews] review granted: [Bug 123316] [Mac MediaStream] implement AVFoundation backed MediaStreamSource : [Attachment 215329] Updated patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 123316: [Mac MediaStream] implement AVFoundation backed MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=123316

Attachment 215329: Updated patch
https://bugs.webkit.org/attachment.cgi?id=215329&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215329&action=review


r=me, with a few nits.

> Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm:323
> +Vector<RefPtr<TrackSourceInfo>> AVCaptureDeviceManager::getSourcesInfo(const
String& /*requestOrigin*/)

Why is this commented out?  Can we either uncomment and add a UNUSED_PARAM() or
remove it?

> LayoutTests/fast/mediastream/MediaStreamTrack.html:28
> +counter = 0;
> +var t = [];

Weird indentation.

> LayoutTests/fast/mediastream/MediaStreamTrack.html:31
> +t[counter++] = event.target;

Ditto.

> LayoutTests/fast/mediastream/MediaStreamTrack.html:84
> +		       debug("	  " + i + " : " + list[i]);

Ditto.