[webkit-reviews] review granted: [Bug 123448] [GTK] DOM bindings documentation errors : [Attachment 215396] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 29 10:34:22 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 123448: [GTK] DOM bindings documentation errors
https://bugs.webkit.org/show_bug.cgi?id=123448

Attachment 215396: Patch
https://bugs.webkit.org/attachment.cgi?id=215396&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215396&action=review


Looks great, thanks. Please add also the description for return tags having a
g-i annotation too.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:980
>	   push(@hBody, " * Returns: (transfer none):\n");

Sorry I missed this one before, but this would be empty too, it doesn't give a
warning because of the g-i annotation, but it should also have a description.


More information about the webkit-reviews mailing list