[webkit-reviews] review granted: [Bug 123446] Multiple runs per line on simple line path : [Attachment 215389] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 123446: Multiple runs per line on simple line path
https://bugs.webkit.org/show_bug.cgi?id=123446

Attachment 215389: patch
https://bugs.webkit.org/attachment.cgi?id=215389&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215389&action=review


r=me.

> Source/WebCore/rendering/SimpleLineLayout.cpp:263
> +	   Vector<Run, 4> lineRuns;
> +	   lineRuns.append(Run(lineStartOffset, 0));

This can be an uncheckedAppend() since we know there is space in the inline
capacity here.

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:45
> +	   Run(const Iterator&);

explicit

>> Source/WebCore/rendering/SimpleLineLayoutResolver.h:98
>> +	    Iterator(RunResolver::Iterator&&);
> 
> Missing spaces around &&  [whitespace/operators] [3]

explicit

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:244
> +    rect.unite((*it).rect());

No need to declare "rect" before this line.
LayoutRect rect = (*it).rect();