[webkit-reviews] review granted: [Bug 123353] [MSE] Add MediaSource compatible loading functions to MediaPlayer : [Attachment 215197] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 123353: [MSE] Add MediaSource compatible loading functions to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=123353

Attachment 215197: Patch
https://bugs.webkit.org/attachment.cgi?id=215197&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215197&action=review


> Source/WebCore/Modules/mediasource/MediaSource.cpp:207
> -    return
MIMETypeRegistry::isSupportedMediaSourceMIMEType(contentType.type(), codecs);
> +    return MediaPlayer::supportsType(contentType, emptyString(), URL(), 0,
true) != MediaPlayer::IsNotSupported;

Can you remove MIMETypeRegistry::isSupportedMediaSourceMIMEType now?

> Source/WebCore/platform/graphics/MediaPlayer.cpp:744
> +MediaPlayer::SupportsType MediaPlayer::supportsType(const ContentType&
contentType, const String& keySystem, const URL& url, const
MediaPlayerSupportsTypeClient* client, bool isMediaSource)

We will have to modify this again for MediaStream so this one bool won't last
long. Why not just pass the MediaEngineSupportParameters struct?