[webkit-reviews] review granted: [Bug 123414] RenderElement::style() should return a reference. : [Attachment 215354] It's happening!
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 28 19:18:40 PDT 2013
Anders Carlsson <andersca at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 123414: RenderElement::style() should return a reference.
https://bugs.webkit.org/show_bug.cgi?id=123414
Attachment 215354: It's happening!
https://bugs.webkit.org/attachment.cgi?id=215354&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215354&action=review
>> Source/WebCore/editing/DeleteSelectionCommand.cpp:585
>> + ASSERT(!textNode->renderer()
||textNode->renderer()->style().collapseWhiteSpace());
>
> Missing spaces around | [whitespace/operators] [3]
Please fix.
>> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:364
>> + unsigned int flexGroup = child->style().boxFlexGroup();
>
> Omit int when using unsigned [runtime/unsigned] [1]
Yes, omit int please.
More information about the webkit-reviews
mailing list