[webkit-reviews] review granted: [Bug 123429] Add tooltips to the platform icons in Dashboard : [Attachment 215356] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 123429: Add tooltips to the platform icons in Dashboard
https://bugs.webkit.org/show_bug.cgi?id=123429

Attachment 215356: Patch
https://bugs.webkit.org/attachment.cgi?id=215356&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215356&action=review


r=me

I would personally prefer the text to be just always visible, but even a
tooltip is an improvement.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
uildbot.js:44
> +    MacOSXMavericks: { name: "mac-os-x-mavericks", readablename: "Mac OS X
Mavericks", order: 10 },

Does "readablename" match the style in this file? Should be readableName
otherwise.

Please remove "Mac", it's just "OS X Mavericks".

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
uildbot.js:46
> +    MacOSXMountainLion: { name: "mac-os-x-mountain-lion", readablename: "Mac
OS X MountainLion", order: 20 },
> +    MacOSXLion: { name : "mac-os-x-lion", readablename: "Mac OS X
MountainLion", order: 30 },

Please add a space in "Mountain Lion", and remove "Mac".