[webkit-reviews] review requested: [Bug 117039] [GStreamer] Support audio and video tracks : [Attachment 215335] Add TrackPrivateBase base class.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 28 14:23:16 PDT 2013


Brendan Long <b.long at cablelabs.com> has asked  for review:
Bug 117039: [GStreamer] Support audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=117039

Attachment 215335: Add TrackPrivateBase base class.
https://bugs.webkit.org/attachment.cgi?id=215335&action=review

------- Additional Comments from Brendan Long <b.long at cablelabs.com>
This adds a TrackPrivateBase and TrackPrivateBaseClient (I'm not exactly sure
about the names), so the *TrackPrivate classes can share some code. I'm looking
at doing a PIMPL for the *TrackPrivateGStreamer classes to share code. I also
added labelChanged() and languageChanged() to AudioTrack and VideoTrack to make
them consistent. Is it easier to review if I split individual commits like
this?


More information about the webkit-reviews mailing list