[webkit-reviews] review granted: [Bug 123347] Refactor IDB factory creation : [Attachment 215200] Patch v1

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 123347: Refactor IDB factory creation
https://bugs.webkit.org/show_bug.cgi?id=123347

Attachment 215200: Patch v1 
https://bugs.webkit.org/attachment.cgi?id=215200&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215200&action=review


r=me

> Source/WebCore/Modules/indexeddb/PageGroupIndexedDatabase.h:47
> +    PageGroupIndexedDatabase(const String& databaseDirectoryIdentifier);

explicit

> Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h:49
> +    WorkerGlobalScopeIndexedDatabase(const String&
databaseDirectoryIdentifier);

explicit

> Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:72
> +    IDBFactoryBackendLevelDB(const String& databaseDirectory);

explicit

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:51
> +    WebIDBFactoryBackend(const String& databaseDirectoryIdentifier);

explicit

>
Source/WebKit2/WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:46

> +    static PassRefPtr<WebProcessIDBDatabaseBackend>
create(WebIDBFactoryBackend* factory, const String& name) { return adoptRef(new
WebProcessIDBDatabaseBackend(factory, name)); }

We should pass the WebIDBFactoryBackend by reference here, since null is not a
valid input.