[webkit-reviews] review granted: [Bug 122963] [CSSRegions] Display anonymous regions in DRT : [Attachment 215291] Patch 5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 28 11:08:25 PDT 2013


Alexandru Chiculita <achicu at adobe.com> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 122963: [CSSRegions] Display anonymous regions in DRT
https://bugs.webkit.org/show_bug.cgi?id=122963

Attachment 215291: Patch 5
https://bugs.webkit.org/attachment.cgi?id=215291&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215291&action=review


Thanks Mihnea!

> Source/WebCore/rendering/RenderTreeAsText.cpp:703
> +	   writeIndent(ts, indent + 3);

nit: I think the +3 should happen in the caller method.

> Source/WebCore/rendering/RenderTreeAsText.cpp:715
> +		   ts << " (anonymous child of)";

nit: I guess ")" should come at the end after the generated element is printed
out.


More information about the webkit-reviews mailing list