[webkit-reviews] review granted: [Bug 123367] Web Inspector: Implement TimelineRecording and per-callsite timelines : [Attachment 215224] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 123367: Web Inspector: Implement TimelineRecording and per-callsite
timelines
https://bugs.webkit.org/show_bug.cgi?id=123367

Attachment 215224: Patch
https://bugs.webkit.org/attachment.cgi?id=215224&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215224&action=review


r=me

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:32
> +    this._timelines = {script: new WebInspector.Timeline, layout: new
WebInspector.Timeline};
> +    this._sourceCodeTimelinesMap = new Map;
> +    this._eventMarkers = [];

When are these cleared?

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:41
> +    get timelines() {

Style: { on its own line